Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 25, 2023

Description

  • Rename Views/Pages/Properties*.xaml(.cs) with Views/Properties/*.xaml(.cs)
  • Rename ViewModels/Properties/*Properties.cs with ViewModels/Properties/*.cs

Motivation and Context

Validation

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

Solution Explorer
image

@0x5bfa 0x5bfa marked this pull request as ready for review February 25, 2023 04:43
@yaira2 yaira2 requested a review from d2dyno1 February 26, 2023 00:36
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Feb 26, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 26, 2023

@onein528 can you fix the merge conflicts?

yaira2
yaira2 previously approved these changes Feb 26, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 26, 2023

Wait a moment.

@yaira2
Copy link
Member

yaira2 commented Feb 26, 2023

The only thing that's changed was some strings but that shouldn't be causing this kind of conflict

@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 26, 2023

Done. (I've changed C# filename in Properties, thus this could occurred)

@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 26, 2023

@yaira2 Done.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Feb 26, 2023
@yaira2 yaira2 merged commit aead557 into files-community:main Feb 26, 2023
@0x5bfa 0x5bfa deleted the 5bfa/reorg-propspages branch March 1, 2023 04:52
@0x5bfa 0x5bfa restored the 5bfa/reorg-propspages branch March 1, 2023 04:52
@0x5bfa 0x5bfa deleted the 5bfa/reorg-propspages branch March 1, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants