chore: conditionally change the limit of F3 certs listed via CLI #12669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
added
release/backport
skip/changelog
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment)
masih
force-pushed
the
masih/cert-list-conditional-limit
branch
from
3d51bc0 to
36cb11f
Compare
Stebalien
approved these changes
Nov 1, 2024
18 tasks
masih
added a commit
that referenced
this pull request
Nov 4, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment) (cherry picked from commit 773efae)
rjan90
pushed a commit
that referenced
this pull request
Nov 6, 2024
* When no range is given, default limit to 10 * Otherwise default to unlimited. This is better than the current default of always unlimited because: * there are a lot of certs, and * when range is given the chances are the user wants all of them. Addresses #12627 (comment) (cherry picked from commit 773efae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Addresses #12627 (comment)
Proposed Changes
This is better than the current default of always unlimited because:
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: