Replace ExecutedAndBlockMessages with individual methods

[frrist]

What

This PR removes the ExecutedAndBlockMessages method and replaces it smaller more specific methods: TipSetMessageReceipts, TipSetBlockMessages, and ComputeGasOutputs.

While implementing, I noticed a few bugs in the now replaced ExecutedAndBlockMessages method, which are tracked in #1045 and #1043 and fixed in this PR. Furthermore, I took the opportunity to address #1041 while implementing TipSetMessageReceipts.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.4%. Comparing base (593dad6) to head (f3d0d2e).
⚠️ Report is 208 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1040     +/-   ##
========================================
- Coverage    34.4%   34.4%   -0.1%     
========================================
  Files          44      44             
  Lines        2925    2930      +5     
========================================
  Hits         1008    1008             
- Misses       1821    1826      +5     
  Partials       96      96             

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kasteph]

Suggested change

	func (mri *MessageReceiptIterator) Next() (types.ChainMsg, int, *types.MessageReceipt) {
	func (mri *MessageReceiptIterator) Next() (types.ChainMsg, *types.MessageReceipt) {

is the index necessary as part of the return value? i did a quick scan of where this is being called and only saw it once here.

could the index also be accessed as:

msg, rec := itr.Next()
idx := itr.exeIdx[msg]

[frrist]

Ah, I will comment this, idx is the messages execution index in the tipset - the order the message was executed in relative to other messages in the tipset.

[kasteph]

What does pts mean? parent tipset?

[frrist]

Parent tipset yes. aka ts.Parent()

[kasteph]

I didn't see any glaring logical errors in any of the tasks nor in the TipSetMessageReceipts() function. My previous comments are not blockers.

[placer14]

Suggested change

	func (t *DataSource) ShouldBrunFn(ctx context.Context, ts *types.TipSet) (lens.ShouldBurnFn, error) {
	func (t *DataSource) ShouldBurnFn(ctx context.Context, ts *types.TipSet) (lens.ShouldBurnFn, error) {

[placer14]

Suggested change

	// so we only load the receipt array one
	// so we only load the receipt array once

[placer14]

Is the VM very "heavy" in size? Should vmi be memoized within LilyNodeAPI and have the appropriate statetree applied at the time of request within the wrapper?

[frrist]

Great question. Currently, this method is only called by the GasOuptut task, so until another task needs to call this method we can leave out caching.

[frrist]

#1045 fixed here, this calls the lotus ComputeBaseFee method directly: https://github.com/filecoin-project/lotus/blob/master/chain/store/basefee.go#L50

[frrist]

fixes #1043 by correctly calculating the message size on chain:
https://github.com/filecoin-project/lotus/blob/v1.17.0/chain/types/message.go#L81
https://github.com/filecoin-project/lotus/blob/v1.17.0/chain/types/signedmessage.go#L81

[frrist]

I have implemented this method in lotus: filecoin-project/lotus#9186, initial review (walked through with the lotus team together) suggests this is correct - as does the comparison with existing data in the production database. Once filecoin-project/lotus#9186 merges I will replace this with a direct call to the lotus method.

[frrist]

These tasks were simplified to require a single tipset to operate, resulting from the removal of ExecutedAndBlockMessages which requires a child and a parent tipset.

[frrist]

Parent tipset yes. aka ts.Parent()

[frrist]

Ah, I will comment this, idx is the messages execution index in the tipset - the order the message was executed in relative to other messages in the tipset.

[frrist]

Great question. Currently, this method is only called by the GasOuptut task, so until another task needs to call this method we can leave out caching.