Add verifreg balance to datacap #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor proposal traversal to outside of migrations for efficiency
ZenGround0
commented
Oct 21, 2022
| return nil | ||
| for _, dealID := range pendingDeals { | ||
| proposal, err := proposals.GetDealProposal(dealID) | ||
| if err != nil || proposal == nil { |
There was a problem hiding this comment.
proposal == nil should not be reachable but I figured an explicit error is minutely nicer than a panic
arajasek
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors full proposal traversal to a single preliminary call that collects deal IDs of verified pending deals for verifreg migration and their total size for datacap migration