Skip to content

Conversation

@snadrus
Copy link
Contributor

@snadrus snadrus commented Oct 15, 2025

Make our Ingest & Address configuration dynamic such that the values apply instantly.

Market will ERROR on 0 <--> 1 that a restart is required to enable the correct services.

Discoveries
Computed Values: These become their own config.NewDynamic() which gets updated by a callback on the source(s).
I could be persuaded to turn these into event streams into reactive programming: https://github.com/samber/ro

I don't think we should be stopping & starting services on these changes. That will simply be unsupported.

Bad configuration is setup to throw error and reuse the original in all the secondary-interpretations, otherwise it'll stream out errors until fixed in the direct consumptions. These seem reasonable.

I couldn't get TOML to do value unmarshal as it knows documents only at the top level, so I built an ugly wrapper full of reflection that we should use instead of TOML unmarshal. It works, but it's ugly.

BTW, also made descriptions visible (was a mouseover). This will make it easier to see what's dynamic and what's not.
image

@snadrus snadrus requested a review from a team as a code owner October 15, 2025 02:35
@snadrus snadrus requested a review from magik6k October 15, 2025 02:36
@snadrus snadrus marked this pull request as draft October 15, 2025 02:36
@snadrus snadrus marked this pull request as ready for review October 17, 2025 21:57
@snadrus snadrus changed the title Apply dyn-cfg Apply dyn-cfg to p1 cases Oct 17, 2025
@snadrus snadrus requested a review from Reiers October 17, 2025 22:09
@snadrus snadrus requested a review from magik6k October 23, 2025 20:01
@snadrus snadrus enabled auto-merge (squash) October 23, 2025 23:40
@snadrus snadrus disabled auto-merge October 23, 2025 23:40
@snadrus snadrus requested a review from LexLuthr October 29, 2025 14:28
@LexLuthr
Copy link
Contributor

We should Test this with UI and see if new encode/decode works with our weird UI setup.

@snadrus snadrus merged commit ca2e86b into main Nov 5, 2025
18 checks passed
@snadrus snadrus deleted the apply-dyn-cfg branch November 5, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants