Skip to content

EVM: fix zero curve encoding #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: EVM: fix sar behavior, and test bit shifts
merged 3 commits into from
Feb 5, 2023
Merged

EVM: fix zero curve encoding #1164

merged 3 commits into from
Feb 5, 2023

Conversation

@raulk
Copy link
Member

@raulk raulk commented Feb 4, 2023 •
edited
Loading

@raulk raulk mentioned this pull request Feb 4, 2023
Closed
@Stebalien Stebalien force-pushed the raulk/reproduce-ecmul-zero-bug branch 2 times, most recently from 9760848 to 6dad36c Compare February 4, 2023 21:26
@Stebalien Stebalien force-pushed the raulk/reproduce-ecmul-zero-bug branch from 6dad36c to dbc2a5d Compare February 4, 2023 21:31
@Stebalien Stebalien marked this pull request as ready for review February 4, 2023 21:37
@Stebalien Stebalien changed the title EVM: reproduce ecMul precompile zero-scalar bug. EVM: fix zero curve encoding Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023 •
edited
Loading

Codecov Report

Merging #1164 (342fce3) into next (6540db3) will decrease coverage by 0.16%.
The diff coverage is 89.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1164      +/-   ##
==========================================
- Coverage   81.81%   81.65%   -0.16%     
==========================================
  Files         131      131              
  Lines       26559    26555       -4     
==========================================
- Hits        21728    21684      -44     
- Misses       4831     4871      +40
Impacted Files Coverage Δ
actors/evm/src/interpreter/precompiles/evm.rs 72.48% <89.65%> (-7.94%) ⬇️
runtime/src/util/message_accumulator.rs 93.63% <0.00%> (-0.91%) ⬇️
actors/evm/src/reader.rs 49.70% <0.00%> (-0.59%) ⬇️
actors/power/src/lib.rs 83.58% <0.00%> (+0.21%) ⬆️
state/src/check.rs 86.35% <0.00%> (+0.26%) ⬆️
...ors/evm/src/interpreter/instructions/arithmetic.rs 92.18% <0.00%> (+0.52%) ⬆️
actors/miner/src/deadline_info.rs 96.62% <0.00%> (+16.85%) ⬆️

raulk
raulk commented Feb 4, 2023
View reviewed changes
Copy link
Member Author

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Stebalien Stebalien enabled auto-merge (squash) February 4, 2023 22:59
@Stebalien Stebalien disabled auto-merge February 5, 2023 02:04
@Stebalien Stebalien enabled auto-merge (squash) February 5, 2023 02:04
@Stebalien Stebalien merged commit d098549 into next Feb 5, 2023
@Stebalien Stebalien deleted the raulk/reproduce-ecmul-zero-bug branch February 5, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raulk @codecov-commenter @Stebalien