Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.

fix: remove spaces before command output #31

Merged
merged 1 commit into from
Aug 21, 2018
Merged

fix: remove spaces before command output #31

merged 1 commit into from
Aug 21, 2018

Conversation

eine
Copy link
Contributor

@eine eine commented Aug 21, 2018

The first line of output of the execution of a command is shown with additional margin:

        -rwxrwxr-x. 1 user user 14 Aug 20 18:41 ./atest.md
-rwxrwxr-x. 1 user user 21 Aug 20 18:41 ./anothertest.txt

This PR fixes it by removing spaces in the HTML source.

@eine eine requested a review from hacdias August 21, 2018 00:42
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves the issue, but there must be another way though.

@eine
Copy link
Contributor Author

eine commented Aug 21, 2018

At first I tried:

        <pre v-else-if="commands.length > 0"><!---
          --><template v-for="c in commands">{{ c }}</template><!--
        --></pre>

which works too. But I find it ugly.

@hacdias
Copy link
Member

hacdias commented Aug 21, 2018

Yes, it's ugly eheh

@eine
Copy link
Contributor Author

eine commented Aug 21, 2018

It seems to be tricky to change:

So I am going to merge this, and we will update it if we find a better alternative.

@eine eine merged commit 1e5ced6 into filebrowser:master Aug 21, 2018
@eine eine removed the in progress label Aug 21, 2018
@eine eine deleted the fix/spaces-before-cmd-output branch August 21, 2018 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants