Add MarkupContent and TextDocumentSyncOptions, remove unused uses #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements Fixes felixfbecker#4 Fix typos, remove unused use statements
TysonAndre
force-pushed
the
add-markup-and-sync-options
branch
from
7ac55b0 to
234bbcd
Compare
src/MarkupKind.php
Outdated
| { | ||
| /** | ||
| * Plain text is supported as a content format | ||
| */ |
There was a problem hiding this comment.
Fixed, this was pasted from https://microsoft.github.io/language-server-protocol/specification
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
joehoyle
added a commit
to joehoyle/php-language-server-protocol
that referenced
this pull request
Feb 22, 2021
It appears this was missed in felixfbecker#5, which sets the property to allow MarkupContent, but doesn't allow instantiating the object with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Fix typos (detected by codespell, should have already been fixed in specification document)
remove unused use statements (detected by Phan)