Add support for get_watermark_offsets #648
Open
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattusifer
changed the title
mattusifer
force-pushed
the
musifer/add-get-watermark-offsets
branch
3 times, most recently
from
21c95b9 to
3f74371
Compare
|
Just want to make sure this is didn't get buried. Is someone able to review? cc @davidblewett |
mattusifer
force-pushed
the
musifer/add-get-watermark-offsets
branch
from
3f74371 to
4678e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new consumer function -
get_watermark_offsets- which leverages the get_watermark_offsets librdkafka binding to return the last known watermark values for a topic/partition. This is essentially a much more efficient version of query_watermark_offsets, which requires a network call to the broker, with some caveats (described in the docs for theget_watermark_offsetsmethod).