Skip to content

Docs/concepts/public api #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 25, 2021
Merged

Docs/concepts/public api #76

merged 25 commits into from
Mar 25, 2021

Conversation

AlexandrHoroshih
Copy link
Contributor

@AlexandrHoroshih AlexandrHoroshih commented Mar 20, 2021 •
edited
Loading

Changelog:

  • Добавил доку о публичном апи модулей приложения

Issue: #54

@AlexandrHoroshih AlexandrHoroshih requested review from azinit, a team and akaia-shadowfox and removed request for a team March 20, 2021 20:36
@azinit azinit linked an issue Mar 20, 2021 that may be closed by this pull request
Добавить доку: "Public API" #54
Closed
@azinit azinit added this to the 2.0.0-alpha.1 milestone Mar 20, 2021
@azinit
Copy link
Member

azinit commented Mar 20, 2021

Заархивировать бы дискуссию основную)

Как на примере:
image

@AlexandrHoroshih
Copy link
Contributor Author

Done

azinit
azinit suggested changes Mar 20, 2021
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне бежать уже пора увы, но вроде как базовое, что в глаза бросалось - отписал

Старался не придираться особо 😄

@azinit
Copy link
Member

azinit commented Mar 20, 2021 •
edited
Loading

@AlexandrHoroshih плюс. я наверное еще в README указал основном - что такая статья появилась (потом более структурированно будем делать, но пока лучше явно давать знать - что появилась новая дока)

https://github.com/feature-sliced/wiki/blob/3d8389d3e6491379e6d2cf4983a8ef242653f640/README.md

image

@AlexandrHoroshih AlexandrHoroshih requested a review from azinit March 21, 2021 18:44
@AlexandrHoroshih
Copy link
Contributor Author

@feature-sliced/core

azinit
azinit suggested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стало гораздо круче, но спойлеры бы поправить для читаемости (приложил предложения - с ними еще лучше должно стать) 🚀

@AlexandrHoroshih AlexandrHoroshih requested a review from azinit March 22, 2021 16:57
azinit
azinit approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Прям топ вышел, хотя я бы все равно некоторые вещи поправил)

Но если что, потом своим PR позж докину, мб вкусовщина уже

А так хорошую работу прям проделал, спасибо!

@azinit
Copy link
Member

azinit commented Mar 25, 2021

@feature-sliced/core заапрувьте еще кто-нить

@azinit azinit added the help wanted Extra attention is needed label Mar 25, 2021
@azinit azinit mentioned this pull request Mar 25, 2021
Closed
@AlexandrHoroshih AlexandrHoroshih merged commit b1af590 into master Mar 25, 2021
@AlexandrHoroshih AlexandrHoroshih deleted the docs/concepts/public-api branch March 25, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@akaia-shadowfox akaia-shadowfox akaia-shadowfox approved these changes

@azinit azinit azinit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AlexandrHoroshih AlexandrHoroshih

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
Спринт 2021_1
Development

Successfully merging this pull request may close these issues.

Добавить доку: "Public API"
3 participants
@AlexandrHoroshih @azinit @akaia-shadowfox