Skip to content

Fixes wasi #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2022
Merged

Fixes wasi #524

merged 2 commits into from
Jan 20, 2022

Conversation

Defman
Copy link
Member

@Defman Defman commented Jan 20, 2022 •
edited
Loading

Fix wasi bug

Status

  • Ready
  • Development
  • Hold

Description

Fixes plugin issue with memory not being initialized on WasiEnv.

Related issues

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

@Defman Defman merged commit b53d7c6 into feather-rs:main Jan 20, 2022
@Defman Defman deleted the wasi branch January 20, 2022 19:43
@Iaiao Iaiao mentioned this pull request Feb 8, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Iaiao Iaiao Iaiao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Defman @Iaiao