Add support for IPv6 address #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently host from URI returned includes square brackets, those were part of IPv6 address(ref:https://datatracker.ietf.org/doc/html/rfc2732) but those brackets shall be removed for creating socket.
|
@jcoglan shall we get this PR merged ? so that I can still use same gem rather than forking and releasing/managing differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently host from URI returned includes square brackets, those were
part of IPv6 address(ref:https://datatracker.ietf.org/doc/html/rfc2732)
but those brackets shall be removed for creating socket.