-
Notifications
You must be signed in to change notification settings - Fork 439
Better raw data #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better raw data #1461
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds an analytics event during enhancement when a template has a context option, introduces english_8 and english_9 data modules with compile-time constants and a new words.json asset, updates data crate exports, and extends seed data (Rust and JSON) to map two new session IDs to the new word lists. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant UI as Editor UI
participant Hook as useEnhanceMutation
participant Analytics
participant Ctx as Context Parser
participant Gen as Generator
User->>UI: Trigger Enhance
UI->>Hook: enhance(selectedTemplate)
alt selectedTemplate has context_option
Hook->>Analytics: event("enhance_with_context", distinct_id)
Hook->>Ctx: parseContext(selectedTemplate.context_option)
Ctx-->>Hook: context
Hook->>Gen: generate(context)
else no context_option
Hook->>Gen: generate()
end
Gen-->>UI: result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.