Skip to content

Minor fixes 0825 #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duckduckhero merged 7 commits into from
Aug 26, 2025
Merged

Minor fixes 0825 #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4fdb42
added hyprcloud posthog check
duckduckhero Aug 25, 2025
ffada0c
changed onboarding words
duckduckhero Aug 25, 2025
5eeb901
minor fixes
duckduckhero Aug 25, 2025
b64964f
fixed logs
duckduckhero Aug 26, 2025
088548f
tool call log
duckduckhero Aug 26, 2025
fa3d646
Merge branch 'main' of https://github.com/fastrepl/hyprnote into mino…
duckduckhero Aug 26, 2025
d6bd8de
ran tests
duckduckhero Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions apps/desktop/src/components/editor-area/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ export function useEnhanceMutation({
await new Promise(resolve => setTimeout(resolve, 100));

const getWordsFunc = sessionId === onboardingSessionId ? dbCommands.getWordsOnboarding : dbCommands.getWords;
const [{ type }, config, words] = await Promise.all([
const [{ type, connection }, config, words] = await Promise.all([
connectorCommands.getLlmConnection(),
dbCommands.getConfig(),
getWordsFunc(sessionId),
Expand Down Expand Up @@ -433,13 +433,15 @@ export function useEnhanceMutation({

const selectedTemplate = await TemplateService.getTemplate(effectiveTemplateId ?? "");

const eventName = selectedTemplate?.tags.includes("builtin")
? "builtin_template_enhancement_started"
: "custom_template_enhancement_started";
analyticsCommands.event({
event: eventName,
distinct_id: userId,
});
if (selectedTemplate !== null) {
const eventName = selectedTemplate?.tags.includes("builtin")
? "builtin_template_enhancement_started"
: "custom_template_enhancement_started";
analyticsCommands.event({
event: eventName,
distinct_id: userId,
});
}

const shouldUseH1Headers = !effectiveTemplateId && h1Headers.length > 0;
const grammarSections = selectedTemplate?.sections.map(s => s.title) || null;
Expand Down Expand Up @@ -477,15 +479,15 @@ export function useEnhanceMutation({
? provider.languageModel("onboardingModel")
: provider.languageModel("defaultModel");

console.log("model: ", model);
console.log("provider: ", provider);
const isHyprCloud = type !== "HyprLocal" && connection && connection.api_base.includes("pro.hyprnote.com");

if (sessionId !== onboardingSessionId) {
analyticsCommands.event({
event: "normal_enhance_start",
distinct_id: userId,
session_id: sessionId,
connection_type: type,
is_hypr_cloud: isHyprCloud,
});
}

Expand Down
6 changes: 6 additions & 0 deletions apps/desktop/src/components/right-panel/hooks/useChatLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,12 @@ export function useChatLogic({
type: "tool-start",
tool_details: JSON.stringify(chunk.input),
});

// log if user is using tools in chat
analyticsCommands.event({
event: "chat_tool_call",
distinct_id: userId || "",
});
}

if (chunk.type === "tool-result" && !(chunk.toolName === "update_progress" && type === "HyprLocal")) {
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/components/welcome-modal/custom-endpoint-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export function CustomEndpointView({
return (
<div className="flex flex-col items-center">
<h2 className="text-xl font-semibold mb-3">
<Trans>Configure Your LLM</Trans>
<Trans>Set up Your AI Provider</Trans>
</h2>

<div className="w-full max-w-lg mb-6">
Expand Down
6 changes: 3 additions & 3 deletions apps/desktop/src/components/welcome-modal/llm-selection-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Trans } from "@lingui/react/macro";
import { Network, ShieldIcon } from "lucide-react";
import { ShieldIcon, Unplug } from "lucide-react";
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify lucide icon names (ShieldIcon/Unplug) against your installed version.

Some lucide-react packages export "Shield" (not "ShieldIcon") and may or may not include "Unplug". If build/typecheck fails, consider aliasing "Shield as ShieldIcon" or falling back to "Plug".

Would you like me to confirm the latest lucide-react exports?

🌐 Web query:

Does lucide-react export Unplug and ShieldIcon as named React components? If not, what are the correct names in the latest version?

💡 Result:

I searched the lucide-react package docs and source. lucide-react does not export components named Unplug or ShieldIcon. In the latest versions the correct exported component names are:

  • Unplug is exported as Unplug2 (named export) [1].
  • ShieldIcon is exported as Shield (named export) [2].

Sources: lucide-react repository and generated icon index [1][2].

References:
[1] https://github.com/lucide-icons/lucide/tree/main/packages/lucide-react/src/icons (icon list shows Unplug2)
[2] https://github.com/lucide-icons/lucide/tree/main/packages/lucide-react/src/icons (icon list shows Shield)

Fix lucide-react icon imports: use correct exports

The lucide-react icon index exposes Shield (not ShieldIcon) and does not include an Unplug export. The index lists “Plug” and “Plug2”, but no “ShieldIcon” or “Unplug” entries (gist.github.com).

Please update your import in apps/desktop/src/components/welcome-modal/llm-selection-view.tsx accordingly:

-import { ShieldIcon, Unplug } from "lucide-react";
+import { Shield as ShieldIcon, Plug2 as Unplug } from "lucide-react";

If “Plug2” isn’t the icon you intended for an “unplug” state, pick the correct name from the lucide-react index (e.g. Plug, PlugZap, etc.).

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In apps/desktop/src/components/welcome-modal/llm-selection-view.tsx around line
2, the current import uses non-existent lucide-react exports (ShieldIcon and
Unplug); change the import to use the actual named export Shield (not
ShieldIcon) and replace Unplug with the correct icon name from lucide-react
(e.g., Plug, Plug2, PlugZap, etc.) that matches the intended "unplug" visual;
update the import line and any JSX references to the renamed icon identifiers so
they match the chosen lucide-react export.


import { Card, CardContent } from "@hypr/ui/components/ui/card";
import PushableButton from "@hypr/ui/components/ui/pushable-button";
Expand Down Expand Up @@ -29,8 +29,8 @@ export function LLMSelectionView({ onContinue }: LLMSelectionViewProps) {
{
id: "byom",
title: "Bring Your Own Model",
subtitle: "I want first-in-class meeting summarization",
icon: Network,
subtitle: "Connect custom APIs, from public providers to private servers",
icon: Unplug,
},
] as const;

Expand Down
8 changes: 6 additions & 2 deletions apps/desktop/src/locales/en/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,8 +558,8 @@ msgid "Complete the configuration to continue"
msgstr "Complete the configuration to continue"

#: src/components/welcome-modal/custom-endpoint-view.tsx:214
msgid "Configure Your LLM"
msgstr "Configure Your LLM"
#~ msgid "Configure Your LLM"
#~ msgstr "Configure Your LLM"

#: src/components/settings/components/calendar/cloud-calendar-integration-details.tsx:63
#~ msgid "Connect"
Expand Down Expand Up @@ -1412,6 +1412,10 @@ msgstr "Select Your Languages"
msgid "Send invite"
msgstr "Send invite"

#: src/components/welcome-modal/custom-endpoint-view.tsx:214
msgid "Set up Your AI Provider"
msgstr "Set up Your AI Provider"

#: src/components/left-sidebar/top-area/settings-button.tsx:101
msgid "Settings"
msgstr "Settings"
Expand Down
8 changes: 6 additions & 2 deletions apps/desktop/src/locales/ko/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,8 +558,8 @@ msgid "Complete the configuration to continue"
msgstr ""

#: src/components/welcome-modal/custom-endpoint-view.tsx:214
msgid "Configure Your LLM"
msgstr ""
#~ msgid "Configure Your LLM"
#~ msgstr ""

#: src/components/settings/components/calendar/cloud-calendar-integration-details.tsx:63
#~ msgid "Connect"
Expand Down Expand Up @@ -1412,6 +1412,10 @@ msgstr ""
msgid "Send invite"
msgstr ""

#: src/components/welcome-modal/custom-endpoint-view.tsx:214
msgid "Set up Your AI Provider"
msgstr ""

#: src/components/left-sidebar/top-area/settings-button.tsx:101
msgid "Settings"
msgstr ""
Expand Down
Loading