Skip to content

fsthttp: support sending StatusEarlyHints #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fsthttp: support sending StatusEarlyHints #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions fsthttp/response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,8 @@ func (resp *responseWriter) Header() Header {
return resp.header
}

var excludeHeadersNoBody = map[string]bool{"Content-Length": true, "Transfer-Encoding": true}

func (resp *responseWriter) WriteHeader(code int) {
if resp.wroteHeaders {
println("fsthttp: multiple calls to WriteHeader")
Expand All @@ -282,11 +284,26 @@ func (resp *responseWriter) WriteHeader(code int) {

resp.abiResp.SetFramingHeadersMode(resp.ManualFramingMode)
resp.abiResp.SetStatusCode(code)

var skip map[string]bool
if code == StatusEarlyHints {
skip = excludeHeadersNoBody
}

for _, key := range resp.header.Keys() {
// don't send body headers if we're sending early hints
if skip[key] {
continue
}
resp.abiResp.SetHeaderValues(key, resp.header.Values(key))
}
resp.abiResp.SendDownstream(resp.abiBody, true)

if code == StatusEarlyHints {
// For early hints, don't mark the headers as "sent" so we can send them again next time.
return
}

resp.wroteHeaders = true
}

Expand All @@ -309,6 +326,9 @@ func (resp *responseWriter) SetManualFramingMode(mode bool) {
}

func (resp *responseWriter) Append(other io.ReadCloser) error {
if !resp.wroteHeaders {
resp.WriteHeader(200)
}
otherAbiBody, ok := other.(*fastly.HTTPBody)
if !ok {
return fmt.Errorf("non-Response Body passed to ResponseWriter.Append")
Expand Down