✅ Add test to make sure .fastapicloudignore can override .gitignore #90
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
patrick91
commented
Oct 4, 2025
patrick91
commented
- 🐛 Fix login url not linked correctly
- ✅ Add test to make sure .fastapicloudignore can override .gitignore
DoctorJohn
reviewed
Oct 6, 2025
| (tmp_path / "main.py").write_text("print('hello')") | ||
| (tmp_path / "static/build").mkdir(exist_ok=True, parents=True) | ||
| (tmp_path / "static/build/style.css").write_text("body { background: #bada55 }") | ||
| # Rignore needs a .git folder to make .gitignore work |
There was a problem hiding this comment.
Are we okay with that restriction?
There was a problem hiding this comment.
maybe? :D the only case I can think of where this is problematic is when you're starting a new project and deploy before creating a git repo 🤔
DoctorJohn
approved these changes
Oct 6, 2025
patrick91
added a commit
that referenced
this pull request
Oct 9, 2025
patrick91
added a commit
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.