Skip to content

Fix typo in read_item GET view #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fix typo in read_item GET view #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb7030
Fix typo in `read_item` GET view
jcaguirre89 Oct 18, 2019
af4016c
:green_heart: Trigger CI
tiangolo Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/backend/app/app/api/api_v1/endpoints/items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def update_item(


@router.get("/{id}", response_model=Item)
def read_user_me(
def read_item(
*,
db: Session = Depends(get_db),
id: int,
Expand All @@ -77,7 +77,7 @@ def read_user_me(
"""
item = crud.item.get(db_session=db, id=id)
if not item:
raise HTTPException(status_code=400, detail="Item not found")
raise HTTPException(status_code=404, detail="Item not found")
if not crud.user.is_superuser(current_user) and (item.owner_id != current_user.id):
raise HTTPException(status_code=400, detail="Not enough permissions")
return item
Expand Down