-
Notifications
You must be signed in to change notification settings - Fork 64
Fix release action #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3816e55
to
e633997
Compare
e633997
to
1217780
Compare
@lemire I realized that even though the release succeeded, the new artifact wasn’t published. After a couple of fixes, I think we’re close to finishing this. However, now I’m getting the following error: ![]() Are you sure the Maven credentials are correct? A few months ago, for simdjson-java, I had to generate a new token because OSSRH was sunset. I believe I followed these instructions: https://central.sonatype.org/pages/ossrh-eol/#publishing-to-central-portal. |
Let us try again |
Ok. It does something, but it is not automated. From what I understand, I still have to manually login and request publication after waiting a really long time, and then... I don't know, hope that it works somehow? |
My goal is to make it fully automated. Let’s give it a bit more time. If it doesn’t show up, I’ll investigate. |
I agree with you. My motivation for adding support for Maven Central is that some organizations are restrictive about which repositories can be used in their projects. They often have an internal proxy or cache for Maven Central; and that’s it. In simdjson-java, I haven’t had any problems so far, and I don’t need to do anything manually, so it’s definitely possible to make this work. However, I’m using Gradle there, so I can’t easily copy the configuration here. Anyway, I will figure this out. |
I agree with this.
from Github CI indeed suggest current setup requires to complete the deployment manually. Though, @lemire, the screenshots Sonatype process is on-going. I do not know njord, but my experience with maven+sonatype does not require any manual validation (through the publication may take hours to be fully completed). Though, I never fully automated it through CI. I looked through njord to enable automated publication, but it may be a lacking option. I rely on configuration like:
(https://github.com/solven-eu/adhoc/blob/master/pom.xml#L685-L696). |
Ok. So it only took EIGHT HOURS. |
It works now, so I have entered some comments in a related RoaringBitmap issue: RoaringBitmap/RoaringBitmap#749 |
Did you need to click anything in Maven Central? |
@piotrrzysko Not with the latest setup. |
It looks like the release succeeded:
I'm waiting for the packages to appear in Maven Central. If everything looks good, I'll update the README.