Calculate max compressed length #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good addition. |
Calculating the maximum compressed length is now implemented for all schemes except: * Kamikaze — as stated in the Javadoc, it is not intended for production use. * VectorFastPFOR — it does not appear to be supported for production yet, as it is not included in the release package.
Since we can now calculate the maximum compressed length, there is no longer a need to handle underestimated output array lengths by throwing this exception.
piotrrzysko
force-pushed
the
maxCompressedLength
branch
from
3c6fc7c to
1d2749f
Compare
|
I addressed the remaining schemes except:
|
|
Running tests. If they go green, I will recommend merging. |
|
The build is green. Could you please merge the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this library!
This work is not finished yet, since computing the maximum compressed length is not implemented for all schemes. So far, I've added support only for the headless compression versions of bit-packing and variable byte.
I wanted to get quick feedback before spending more time analyzing the other schemes.
Motivation for this change
Compressorclasses:input.length + input.length / 100 + 1024Notes
For bit-packing and variable byte, the estimation could be made even more precise if we could pass the maximum bit width of the input array to
maxHeadlessCompressedLength. In my case, this value is known, but I'm not sure if that applies to other schemes or whether it's a general enough case for the library.