Skip to content

Make some matrix conversion jittable #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

una-dinosauria
Copy link

@una-dinosauria una-dinosauria commented Oct 24, 2021

Make sure the functions

matrix_to_axis_angle,
matrix_to_euler_angles,
matrix_to_quaternion,
matrix_to_rotation_6d,

from rotation_conversion are jittable.

Add tests to verify this is the case.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2021
@facebook-github-bot
Copy link
Contributor

@bottler has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@una-dinosauria
Copy link
Author

oh no did I break something? :c

@facebook-github-bot
Copy link
Contributor

@bottler merged this pull request in bee31c4.

@bottler
Copy link
Contributor

bottler commented Oct 26, 2021

oh no did I break something? :c

Not at all. Thank you very much for the contribution! I added scripting to some other functions in the same file into the commit that got merged. (The automated CI which shows on github has been mostly failing for a while for unrelated reasons.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants