Skip to content

[Lighting Module] Add half_lambert & blinn_phong #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tomguluson92
Copy link

@tomguluson92 tomguluson92 commented Feb 8, 2020

Hi,
Since I found there is only a basic phong renderer for specular and lambert renderer for diffuse . I add two commonly used renderer: blinn_phong and half_lambert to strengthen the APIs.

With no intention of do damage to the consistency of current API, I add a little bit about interfaces in `lighting.py`, `shading.py` and `shader.py`. 

Plus, it will be a great honor for me if this helps, thanks a lot for your brilliant pytorch3D repo!

@facebook-github-bot
Copy link
Contributor

Hi @tomguluson92!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 8, 2020
@nikhilaravi
Copy link
Contributor

@tomguluson92 thanks for making this PR and apologies for the late response! We will review the code and reply back with comments. Stay tuned!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tomguluson92
Copy link
Author

@tomguluson92 thanks for making this PR and apologies for the late response! We will review the code and reply back with comments. Stay tuned!

Thanks ^.^

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants