-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Non-square mesh rasterizer? #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@wangg12 Thank you for raising this issue! Rendering of non square images is on our roadmap. If you are interested in trying to implement this feature, please update this issue with a detailed outline of your plan and we can review it, following which you are welcome to submit a pull request. |
I'm also quite interested in this feature! |
@jbohnslav We are planning to implement this soon. |
This feature is critical! |
Hi @nikhilaravi , I am also interested in this feature. |
@bhadresh74 we are currently working on this feature! |
Hi @nikhilaravi, I am also interested in this particular feature. I will give it try for a pure optimisation based method I'm working on. Is there any approximate time frame for this? |
Hi @soubhiksanyal! :) It certainly looks like this is a popular feature request :) We have been working on this feature and will aim to have it ready in the next few weeks. I'll update this issue with a more accurate time estimate soon. |
Any update on this? |
@nikhilaravi I am new to pytorch3d, and this issue make me wonder whether it is the best choice. |
Hi @luoyuxuan0528 |
Sorry for that. Looking forward to this feature! @gkioxari @nikhilaravi |
Hi all, do you have an internal PR / plan for this issue you'd be willing to share? I'm interested in contributing to this issue, as it is essential for my project. |
This feature will be added by end of year! |
Great, thank you @gkioxari! If you need any help / work done, I'd be happy to |
@jbohnslav @luoyuxuan0528 @samxuxiang @soubhiksanyal @bhadresh74 @czkg @wangg12 what are your use cases for non square image rasterization? e.g. do you want to vary the number of pixels in X and Y but maintain square pixels? We will be releasing an implementation shortly and want to check that it meets your use cases. |
@nikhilaravi Quick question, are you also planning to add new class to handle camera perspective to allow non-square image for rasterization? |
Yes, I want to do exactly that. I'm working with real cameras, which have square pixels but rectangular sensors. |
We are not changing the cameras. If you want to use non square images with square pixels you don't need to change any of the camera parameters. |
This feature is now available in PyTorch3D for pointcloud and mesh rasterization. Please read this note for details on how to set the (H, W) correctly for rasterizing non square images. |
🚀 Feature
Motivation
Pitch
NOTE: we only consider adding new features if they are useful for many users.
The text was updated successfully, but these errors were encountered: