Skip to content

Can't import MeshRendererWithFragments #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aja9675 opened this issue Mar 1, 2022 · 5 comments
Closed

Can't import MeshRendererWithFragments #1098

aja9675 opened this issue Mar 1, 2022 · 5 comments
Assignees
@bottler

Comments

@aja9675
Copy link

aja9675 commented Mar 1, 2022

🐛 Bugs / Unexpected behaviors

Can't import MeshRendererWithFragments

Instructions To Reproduce the Issue:

from pytorch3d.renderer import MeshRendererWithFragments

Error message:
ImportError: cannot import name 'MeshRendererWithFragments' from 'pytorch3d.renderer.mesh'

This patch fixed the issue for me:
MeshRendererWithFragments.txt
@gkioxari gkioxari added installation Installation questions or issues and removed installation Installation questions or issues labels Mar 1, 2022
@bottler
Copy link
Contributor

bottler commented Mar 1, 2022

Yes, indeed. This class is not exported at higher levels. You can use it with

from pytorch3d.renderer.mesh.renderer import MeshRendererWithFragments

@aja9675
Copy link
Author

aja9675 commented Mar 1, 2022

So this is intentional?

@bottler
Copy link
Contributor

bottler commented Mar 1, 2022

I don't know and it can be made more available. Thanks for drawing attention to this. It shouldn't be block you, right?

@bottler bottler self-assigned this Mar 1, 2022
@aja9675
Copy link
Author

aja9675 commented Mar 1, 2022

Correct, it's not blocking me. I just assumed it was an oversight and should be fixed. If that's not the case, we can close the issue.

@gkioxari
Copy link
Contributor

gkioxari commented Mar 3, 2022

Feel free to submit a pull request. And thank you for bringing it up!

@gkioxari gkioxari closed this as completed Mar 3, 2022
facebook-github-bot pushed a commit that referenced this issue Mar 11, 2022
@bottler @facebook-github-bot
add MeshRendererWithFragments to __init__s
57a33b2 
Summary: As noticed in #1098 , it would be useful to make this more available.

Reviewed By: nikhilaravi

Differential Revision: D34752526

fbshipit-source-id: 5a127bd557a0cd626f36bf194f22bc0a0a6a2436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bottler bottler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bottler @gkioxari @aja9675