Remove RecipeModel from fairseq2.recipe.internal #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbalioglu
requested review from
MartinGleize,
cirquit and
zyaoj
as code owners
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the bulky, but boilerplate part of the
RecipeModeldeprecation work. Although it touches many files, essentially what it does is mainly replacing occurrences ofRecipeModel,RecipeTokenizer, andRecipeDatasetwith internal_ModelHolder,_TokenizerHolder, and_DatasetHoldertypes. It also renames some of the internal types to shorter names to slightly improve readability. It introduces no behavioral changes and is fully backwards-compatible.The essential (internal) changes are included in
src/fairseq2/recipes/model.pyandsrc/fairseq2/recipes/base.py.Verified correctness by running all available recipes (including @cirquit's wav2vec2 recipes) and checking bitwise parity with the main branch.