Add a DOCTYPE to the stream if the <html> tag is rendered at the root #21680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a lot easier to render the whole document using React without needing to patch into the stream. We expect that currently people will still have to patch into the stream to do advanced things but eventually the goal is that you shouldn't need to.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: dbe3363...5ef310a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gaearon
reviewed
Jun 14, 2021
| ); | ||
| startWriting(); | ||
| jest.runAllTimers(); | ||
| expect(output.result).toMatchInlineSnapshot( |
Collaborator
There was a problem hiding this comment.
fancy, I forgot this already works
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
…1680) This makes it a lot easier to render the whole document using React without needing to patch into the stream. We expect that currently people will still have to patch into the stream to do advanced things but eventually the goal is that you shouldn't need to.
3 tasks
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 17, 2021
React-dom renders doctype automatically when `<html>` is detected. We should append `DOCTYPE` prefix only when necessary. x-ref: facebook/react#21680 ## Bug  - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
React-dom renders doctype automatically when `<html>` is detected. We should append `DOCTYPE` prefix only when necessary. x-ref: facebook/react#21680 ## Bug  - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a lot easier to render the whole document using React without needing to patch into the stream.
We expect that currently people will still have to patch into the stream to do advanced things but eventually the goal is that you shouldn't need to once we have enough escape hatches to inject into the stream.
I couldn't update the
/ssr2/fixture yet since that installs a public version rather than installs React from source builds.