Skip to content

DevTools Profiler commit selector wraps around #17760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

DevTools Profiler commit selector wraps around #17760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions packages/react-devtools-shared/src/devtools/views/Profiler/SnapshotSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,20 @@ export default function SnapshotSelector(_: Props) {

const viewNextCommit = useCallback(
() => {
const nextCommitIndex = Math.min(
((selectedFilteredCommitIndex: any): number) + 1,
filteredCommitIndices.length - 1,
);
let nextCommitIndex = ((selectedFilteredCommitIndex: any): number) + 1;
if (nextCommitIndex === filteredCommitIndices.length) {
nextCommitIndex = 0;
}
selectCommitIndex(filteredCommitIndices[nextCommitIndex]);
},
[selectedFilteredCommitIndex, filteredCommitIndices, selectCommitIndex],
);
const viewPrevCommit = useCallback(
() => {
const nextCommitIndex = Math.max(
((selectedFilteredCommitIndex: any): number) - 1,
0,
);
let nextCommitIndex = ((selectedFilteredCommitIndex: any): number) - 1;
if (nextCommitIndex < 0) {
nextCommitIndex = filteredCommitIndices.length - 1;
}
selectCommitIndex(filteredCommitIndices[nextCommitIndex]);
},
[selectedFilteredCommitIndex, filteredCommitIndices, selectCommitIndex],
Expand Down Expand Up @@ -141,7 +141,7 @@ export default function SnapshotSelector(_: Props) {
<span className={styles.IndexLabel}>{label}</span>
<Button
className={styles.Button}
disabled={selectedFilteredCommitIndex === 0 || numFilteredCommits === 0}
disabled={numFilteredCommits === 0}
onClick={viewPrevCommit}
title="Select previous commit">
<ButtonIcon type="previous" />
Expand Down Expand Up @@ -173,10 +173,7 @@ export default function SnapshotSelector(_: Props) {
</div>
<Button
className={styles.Button}
disabled={
selectedFilteredCommitIndex === null ||
selectedFilteredCommitIndex >= numFilteredCommits - 1
}
disabled={numFilteredCommits === 0}
onClick={viewNextCommit}
title="Select next commit">
<ButtonIcon type="next" />
Expand Down