Avoid JSX in ReactCSSTransitionGroup code #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supposedly we want these to be plain JS.
Member
|
Just makes linting easier. I think jshint understands ES6 stuff without a transform. But maybe we should just use jsxhint/eslint (wishlist)? |
zpao
added a commit
that referenced
this pull request
Mar 17, 2014
Avoid JSX in ReactCSSTransitionGroup code
This was referenced Sep 16, 2021
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced Nov 27, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly we want these to be plain JS.
@zpao We do use ES6 features though which already require a transform, so perhaps this distinction is moot?