Skip to content

Conversation

@raphamorim
Copy link
Contributor

@raphamorim raphamorim commented Dec 13, 2017

Ref: #11703

ReactFiberHostContext.js

For some reason, in Windows scenario it returns NoContextT as Value

const rootInstance = requiredContext(rootInstanceStackCursor.current); // could return NoContextT, not CX
const context = requiredContext(contextStackCursor.current); // could return NoContextT, not C
const nextContext = getChildHostContext(context, fiber.type, rootInstance);

ReactFiberReconciler.js

getChildHostContext(parentHostContext: C, type: T, instance: CX): CX,

some thoughts @gaearon?

flow working: https://ci.appveyor.com/project/raphamorim/react/build/1.0.52

@raphamorim raphamorim changed the title [WIP] Fix flow windows Fix flow windows Dec 17, 2017
@gaearon gaearon merged commit ef9f1b6 into facebook:master Dec 18, 2017
@gaearon
Copy link
Collaborator

gaearon commented Dec 18, 2017

Thanks. This looks like a Flow bug but let’s work around for now.

@raphamorim raphamorim deleted the fix-flow-windows branch December 18, 2017 12:21
yenshih pushed a commit to yenshih/react that referenced this pull request Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants