Run Jest tests with "development" environment #11612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Nov 21, 2017
| @@ -1,8 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| // React's test can only work in NODE_ENV=test because of how things | |||
Collaborator
Author
There was a problem hiding this comment.
"because of how things are set up" — my favorite kind of description!
trueadm
approved these changes
Nov 21, 2017
raphamorim
pushed a commit
to raphamorim/react
that referenced
this pull request
Nov 27, 2017
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to require setting it to
'test'becauserewrite-modulesstep treated it specially. This prevented us from running tests with otherNODE_ENVvalues.Since we dropped Haste and no longer use
rewrite-modules, we can now run tests with any environment value. I'm changing this to'development'now but will later introduce a'production'mode separately.