Always set pendingProps to the next props #11580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, pendingProps is null if there are no new props since the last commit. When that happens, we bail out and reuse the current props. But it makes more sense to always set pendingProps to whatever the next props will be. In other words, pendingProps is never null: it points to either new props, or to the current props. Modeling it this way lets us delete lots of code branches and is easier to reason about bail outs: just compare the pending props to the current props.
acdlite
force-pushed
the
always-set-pending-props
branch
from
2fc9256 to
9103f02
Compare
sebmarkbage
reviewed
Nov 17, 2017
| let newChild = createWorkInProgress( | ||
| currentChild, | ||
| currentChild.pendingProps, | ||
| currentChild.pendingProps !== null |
There was a problem hiding this comment.
So when is pendingProps null?
There was a problem hiding this comment.
We set it back to null in the complete phase, unless we tear (down-prioritize), in which case the torn props are stored on the current fiber. https://github.com/facebook/react/blob/master/packages/react-reconciler/src/ReactFiberCompleteWork.js#L395-L405
There was a problem hiding this comment.
@sebmarkbage Thanks for pointing that out; realized it's simpler to just never reset pending props. Updated!
acdlite
force-pushed
the
always-set-pending-props
branch
2 times, most recently
from
cdb508a to
c927915
Compare
sebmarkbage
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation,
pendingPropsis null if there are no new props since the last commit. When that happens, we bail out and reuse the current props.But it makes more sense to always set
pendingPropsto whatever the next props will be. In other words,pendingPropsis never null on the work-in-progress: it points to either new props, or to the current props. Modeling it this way lets us delete lots of code branches and is easier to reason about bail outs: just compare the pending props to the current props.