-
Notifications
You must be signed in to change notification settings - Fork 49.9k
Document ReactCSSTransitionGroup #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/docs/09.1-animation.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is terrible. can someone please help me explain it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, this is very confusing so I'd try not documenting it for now. If people ask questions that this will solve then we can try to explain it better then. Until then, I think having it listed here will confuse more people than it'll help.
|
Excuse my ignorance, but where is |
|
They are not called on the initial render of the transition group, only when they are added to an already mounted transition group |
|
...which should probably be documented |
|
@plievone yeah that's right. I think the rationale is that animations are not desired during the first render, as you might want to directly display all the items. This way is more flexible as you can just manually call whatever animation api if you want on mount. |
|
Ok I see -- I just mixed up the lifecycle methods in group vs child when skimming the code. This will be very handy! |
docs/docs/09.1-animation.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
This is called after the
callbackfunction that was passed tocomponentWillEnteris called.
|
Can you update the transitions example too? |
|
I stole the code change because I wanted to try to get a final build together. I'll let you wrap up docs :) |
|
Ping? I'm going to cut tomorrow at some point and would like to not have to double land docs. |
Document ReactCSSTransitionGroup
No description provided.