JSX render won't allow webkitdirectory and directory to be used

[GaryYufei]

I tried to use webkitdirectory and directory in the input DOM. But I found that it is impossible to add these two label to the input DOM. Anyway to solve this problem?

[jimfb]

We currently have a whitelist of supported attributes. We want to remove the whitelist and allow all attributes at some point (#140) but it's tricky because some components pass all attributes to their children.

Edit: Actually, changed my mind, we'll leave this one open to track the addition of webkitdirectory, mozdirectory, and directory until such time as #140 is fixed or these are added.

A #goodfirstbug might be to add these to the whitelist.

[jimfb]

webkitdirectory was added by #3644.

[jimfb]

Still need mozdirectory and directory.

[mikecheb]

#3644 was reverted by @zpao. He makes a good point about camelcase.

Where should we continue this discussion? Here?

Currently I'm working around this by manipulating the DOM node directory in componentDidMount.

[mxstbr]

Any update on this? Taking a cue from #3644, I could submit a PR adding mozdirectory, directory, webkitdirectory and nwdirectory if that's still wanted. /cc @zpao

[zpao]

I think we're pretty unlikely to take it for the next release (very soon) and we'll hopefully get to a point before the next release after that where all attrs will work without the whitelist. So I'm not super inclined to spend any effort here at the moment.

[mxstbr]

Fair enough, I reckon this can be closed then!