-
Notifications
You must be signed in to change notification settings - Fork 25k
[Versions] Set the versions in package.json and React.podspec to 0.0.0-master #5241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…0-master The current versions in these files is 0.12.0, which is out of date. Better to claim no version than the wrong version, so this diff changes the versions to 0.0.0-master. Release branches will still have the correct versions.
|
@facebook-github-bot shipit cc @vjeux |
|
Thx :) |
|
👍 👍 |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/704689026334067/int_phab to review. |
|
There must be a bug in my multi-line handling, seems like it doesn't always catch it :( |
|
Missing a |
$prefix = '@facebook-github-bot ';
$unchecked_commands = array();
foreach ($comments as $comment) {
$body = $comment['body'];
foreach (Str::explode("\n", $body) as $line) {
if (Str::startsWith($line, $prefix)) {
$unchecked_commands[] = array(
'body' => Str::substr($line, Str::len($prefix)),
'author' => $comment['author'],
);
}
}
}I don't see anything off just by staring at it :( |
|
It looks fine to me too. |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/704689026334067/int_phab to review. |
|
@ide random FYI This commit broke This happens even when I remove the "Pods" directory and try again. It looks like |
Summary:In #5241 ide updated the version number to be a fake one so that people wouldn't send in PRs just bumping the version. Unfortunately, this leads to compatibility issues when developing against `master` with 3rd-party components that declare React Native as a `peerDependency`. For example, I'm using [react-native-orientation](https://github.com/yamill/react-native-orientation) which has a peerDependency of `"react-native": ">=0.5"`. I see a few ways to deal with this: 1. Only develop against the releases on npm, not git snapshots. 2. Ask ecosystem projects to not include a minimum version of `react-native` in their peerDependencies. 3. Track the RN release numbers in the git repository (eg it would be 0.19 right now). 4. Make the release number on master huge (1000 in this PR) so it's obviously a fake number but will still comply with >= checks. I don't think option 2 is good because it's reasonable for a package author to want to specify a minimum R Closes #5556 Differential Revision: D3110274 fb-gh-sync-id: 8638157d44ee99945337fbf585936b50699f0341 fbshipit-source-id: 8638157d44ee99945337fbf585936b50699f0341
Summary:In facebook#5241 ide updated the version number to be a fake one so that people wouldn't send in PRs just bumping the version. Unfortunately, this leads to compatibility issues when developing against `master` with 3rd-party components that declare React Native as a `peerDependency`. For example, I'm using [react-native-orientation](https://github.com/yamill/react-native-orientation) which has a peerDependency of `"react-native": ">=0.5"`. I see a few ways to deal with this: 1. Only develop against the releases on npm, not git snapshots. 2. Ask ecosystem projects to not include a minimum version of `react-native` in their peerDependencies. 3. Track the RN release numbers in the git repository (eg it would be 0.19 right now). 4. Make the release number on master huge (1000 in this PR) so it's obviously a fake number but will still comply with >= checks. I don't think option 2 is good because it's reasonable for a package author to want to specify a minimum R Closes facebook#5556 Differential Revision: D3110274 fb-gh-sync-id: 8638157d44ee99945337fbf585936b50699f0341 fbshipit-source-id: 8638157d44ee99945337fbf585936b50699f0341
The current versions in these files is 0.12.0, which is out of date. Better to claim no version than the wrong version, so this diff changes the versions to 0.0.0-master.
Release branches will still have the correct versions.