refactor: rewrite Inspector from Java to Kotlin #50947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
mateoguzmana
requested changes
Apr 27, 2025
Collaborator
mateoguzmana
left a comment
mateoguzmana
left a comment
There was a problem hiding this comment.
Thanks for migrating this file. Overall it looks good, just two small things that can improve this even further
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/Inspector.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/Inspector.kt
Outdated
Show resolved
Hide resolved
19 tasks
mateoguzmana
approved these changes
Apr 27, 2025
Contributor
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @Vin-Xi in 93efaeb When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rewrite of the Inspector class from Java to Kotlin in scope of #50513
Changelog:
[ANDROID] [CHANGED] - Migrated Inspector to Kotlin
Test Plan:
Tested using RNTester app, on both old and new arch, and tested by navigating to multiple pages