Do not generate ReactCodegen.podspec for libraries #50645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While we were refactoring the generation of the podspec, we made a mistake and we started generating the ReactCodegen.podspec for both libraries and apps. This must be generated only for apps. ## Changelog: [iOS][Fixed] - Generate `ReactCodegen.podspec` only for apps. Differential Revision: D72854074
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72854074 |
2 tasks
|
This pull request has been merged in 18a7c8d. |
|
This pull request was successfully merged by @cipolleschi in 18a7c8d When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: facebook#50645 While we were refactoring the generation of the podspec, we made a mistake and we started generating the ReactCodegen.podspec for both libraries and apps. This must be generated only for apps. ## Changelog: [iOS][Fixed] - Generate `ReactCodegen.podspec` only for apps. Reviewed By: fabriziocucci Differential Revision: D72854074 fbshipit-source-id: 5a1d1120e576d4fe4cf8f733793f5a2619278c2b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While we were refactoring the generation of the podspec, we made a mistake and we started generating the ReactCodegen.podspec for both libraries and apps.
This must be generated only for apps.
Changelog:
[iOS][Fixed] - Generate
ReactCodegen.podspeconly for apps.Differential Revision: D72854074