Skip to content

Conversation

@louix
Copy link
Contributor

@louix louix commented Mar 28, 2025

Summary:

Fixes: #48611

Which is caused by the changes from: f1031be (included in 0.76).
The commit was backed out, but didn't land on 0.76: 080c82e, so this PR applies it there too.

The current Expo version (52) is still using 0.76, so I would imagine it's worth applying this and closing the issue.

Changelog:

[IOS] [FIXED] - Multiple modals on old architecture

Test Plan:

import { Button, Modal, Text, View } from "react-native";
import { useState } from "react";

export const App = (): JSX.Element => {
  const [aVisible, setAVisible] = useState(true);
  const [bVisible, setBVisible] = useState(false);

  return (
    <View>
      <Modal visible={aVisible} animationType="slide">
        <View style={{ flex: 1, margin: 100 }}>
          <Text>A</Text>
          <Button
            title="Close"
            onPress={() => {
              setAVisible(false);
              setBVisible(true);
            }}
          />
        </View>
      </Modal>
      <Modal visible={bVisible} animationType="slide">
        <View style={{ flex: 1, margin: 100 }}>
          <Text>B</Text>
          <Button
            title="Close"
            onPress={() => {
              setBVisible(false);
              setAVisible(true);
            }}
          />
        </View>
      </Modal>
    </View>
  );
};

export default App;

…ok#46434)

Summary:
Pull Request resolved: facebook#46434

Original commit changeset: daa0cf95edb2

Original Phabricator Diff: D62202475

Changelog: [Internal]  revert previous modal presentation improvement

Reviewed By: sammy-SC

Differential Revision: D62474041

fbshipit-source-id: a4af6b5361dcc482e9bb3c2f45d614f9494f022e
@facebook-github-bot
Copy link
Contributor

Hi @louix!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@react-native-bot
Copy link
Collaborator

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 25, 2025
@react-native-bot
Copy link
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants