create a heartbeat for device, and not only for debugger #49618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [General][Internal] - create a heartbeat for device, and not only for debugger. Introducing a heartbeat for the connection between the proxy and the device similarly to the one between the proxy and the debugger. This will allow us to: * Most importantly I'd like to track the ping-pong roundtrip to the device as well, to see if we have any anomalies there * Terminate the connection if it is abandoned for 60seconds- this might have a real effect in some case where the device runs remotely * Also keep that connection alive if the other side disconnects after a period of inactivity. While a no-op in our case, this is an implementation detail. It is a no-op because the WebSocket on the Device is implemented by us and is not supposed to drop connections like the browser does. Reviewed By: robhogan Differential Revision: D69990715
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69990715 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Feb 24, 2025
) Summary: Changelog: [General][Internal] - create a heartbeat for device, and not only for debugger. Introducing a heartbeat for the connection between the proxy and the device similarly to the one between the proxy and the debugger. This will allow us to: * Most importantly I'd like to track the ping-pong roundtrip to the device as well, to see if we have any anomalies there * Terminate the connection if it is abandoned for 60seconds- this might have a real effect in some case where the device runs remotely * Also keep that connection alive if the other side disconnects after a period of inactivity. While a no-op in our case, this is an implementation detail. It is a no-op because the WebSocket on the Device is implemented by us and is not supposed to drop connections like the browser does. Reviewed By: robhogan Differential Revision: D69990715
Collaborator
|
This pull request was successfully merged by @vzaidman in 4e7b77e When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 4e7b77e. |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
) Summary: Pull Request resolved: facebook#49618 Changelog: [General][Internal] - create a heartbeat for device, and not only for debugger. Introducing a heartbeat for the connection between the proxy and the device similarly to the one between the proxy and the debugger. This will allow us to: * Most importantly I'd like to track the ping-pong roundtrip to the device as well, to see if we have any anomalies there * Terminate the connection if it is abandoned for 60seconds- this might have a real effect in some case where the device runs remotely * Also keep that connection alive if the other side disconnects after a period of inactivity. While a no-op in our case, this is an implementation detail. It is a no-op because the WebSocket on the Device is implemented by us and is not supposed to drop connections like the browser does. Reviewed By: robhogan Differential Revision: D69990715 fbshipit-source-id: 6bb3a2ed3eaffff9535aa2d0fc8cff0262af022f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Internal] - create a heartbeat for device, and not only for debugger.
Introducing a heartbeat for the connection between the proxy and the device similarly to the one between the proxy and the debugger. This will allow us to:
Reviewed By: robhogan
Differential Revision: D69990715