Add ReactSoftException in ReactHostImpl only when onActivityResult, onNewIntent and onWindowFocusChange do not have the context #44155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56325407 |
Base commit: 4fbc1f2 |
…nNewIntent and onWindowFocusChange do not have the context (facebook#44155) Summary: Add ReactSoftException in ReactHostImpl only when `onActivityResult`, `onNewIntent`and `onWindowFocusChange` do not have the context Changelog: [Android][Fixed] ReactSoftExceptions in ReactHostImpl only when Context is null Differential Revision: D56325407
arushikesarwani94
force-pushed
the
export-D56325407
branch
from
3b62d89 to
145b380
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56325407 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 19, 2024
…nNewIntent and onWindowFocusChange do not have the context (facebook#44155) Summary: Add ReactSoftException in ReactHostImpl only when `onActivityResult`, `onNewIntent`and `onWindowFocusChange` do not have the context Changelog: [Android][Fixed] ReactSoftExceptions in ReactHostImpl only when Context is null Reviewed By: cortinico Differential Revision: D56325407
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 19, 2024
…yResult, onNewIntent and onWindowFocusChange do not have the context (facebook#44155) Summary: Add ReactSoftException in ReactHostImpl only when `onActivityResult`, `onNewIntent`and `onWindowFocusChange` do not have the context Changelog: [Android][Fixed] ReactSoftExceptions in ReactHostImpl only when Context is null Reviewed By: cortinico Differential Revision: D56325407
Contributor
|
This pull request has been merged in ac3261f. |
|
This pull request was successfully merged by @arushikesarwani94 in ac3261f. When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Jun 3, 2024
…nNewIntent and onWindowFocusChange do not have the context (#44155) Summary: Pull Request resolved: #44155 Add ReactSoftException in ReactHostImpl only when `onActivityResult`, `onNewIntent`and `onWindowFocusChange` do not have the context Changelog: [Android][Fixed] ReactSoftExceptions in ReactHostImpl only when Context is null Reviewed By: cortinico Differential Revision: D56325407 fbshipit-source-id: a9f8fd5772fc05d39e72236fb8edfe5f8a9d6a43
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add ReactSoftException in ReactHostImpl only when
onActivityResult,onNewIntentandonWindowFocusChangedo not have the contextChangelog:
[Android][Fixed] ReactSoftExceptions in ReactHostImpl only when Context is null
Differential Revision: D56325407