Clean up old and unused implementation of microtasks #40870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
Base commit: c9d0a00 |
rubennorte
force-pushed
the
export-D49536251
branch
from
7961a93 to
bbcbca0
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 16, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 16, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
rubennorte
force-pushed
the
export-D49536251
branch
from
bbcbca0 to
b77d2d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
rubennorte
force-pushed
the
export-D49536251
branch
from
b77d2d7 to
3d06143
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
rubennorte
force-pushed
the
export-D49536251
branch
from
3d06143 to
37c3fb1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 18, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
rubennorte
force-pushed
the
export-D49536251
branch
from
37c3fb1 to
e0f6066
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 18, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
rubennorte
force-pushed
the
export-D49536251
branch
from
e0f6066 to
1618515
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 18, 2023
Summary: This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251
|
This pull request was exported from Phabricator. Differential Revision: D49536251 |
|
This pull request has been merged in 29bbab5. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 19, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Differential Revision: D49536262 fbshipit-source-id: 95eddd828138a8b06cd59198c025db0f8b05d9e5
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 19, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Differential Revision: D49536262 fbshipit-source-id: 151440260b39573309a9ca05ba12f590bd76b151
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 19, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 19, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 19, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Differential Revision: D49536262 fbshipit-source-id: 0c54988a52cb03b9d12c5576100f7e248c0f8585
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
Summary: Pull Request resolved: #41084 Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / #40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262 fbshipit-source-id: 8f7ce54c266d1f25312a641abc4ef073d019281f
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#40870 This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task"). `drainMicrotasks` is a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead. We'll add the new iteration of microtasks in a following PR. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D49536251 fbshipit-source-id: b8efba2d0310b9e33e65b79c60ad2db1c8109def
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#41084 Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262 fbshipit-source-id: 8f7ce54c266d1f25312a641abc4ef073d019281f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This removes an old experiment to implement microtasks in React Native (which is incorrect now that the runtime scheduler executes multiple tasks per runtime executor "task").
drainMicrotasksis a no-op at the moment in Hermes because the flag isn't set, so this code is essentially dead.We'll add the new iteration of microtasks in a following PR.
Changelog: [internal]
Reviewed By: christophpurrer
Differential Revision: D49536251
See react-native-community/discussions-and-proposals#744