Skip to content

Conversation

@cipolleschi
Copy link
Contributor

Summary:

While inspecting the pipelines for the template, I realized that the caching was failing because the keys were malformed.
This PR fixes the malformed keys adding the missing "

Changelog:

[Internal] - Fix cache keys for the Template

Test Plan:

The template jobs should not fail with error computing cache key: template: cacheKey:1: unterminated quoted string

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 3, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 3, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in cc7ea9e.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against cf9ca56

@cortinico cortinico deleted the cipolleschi/Fix_template_cache branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants