Skip to content

fix(gradle-plugin): fix nightly build regression #37332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(gradle-plugin): fix nightly build regression #37332

wants to merge 1 commit into from

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented May 9, 2023

Summary:

Nightly builds of Android no longer build due to a recent version format change.

Changelog:

[ANDROID] [FIXED] - Fixed nightly builds of Android no longer building due to a recent version format change

Test Plan:

git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version nightly
cd example
yarn android

@tido64 tido64 requested review from cortinico and lunaleaps May 9, 2023 11:04
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels May 9, 2023
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 9, 2023
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in cceef57.

@tido64 tido64 deleted the tido/fix-nightly-builds branch May 9, 2023 13:27
@tido64 tido64 mentioned this pull request May 9, 2023
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunaleaps lunaleaps Awaiting requested review from lunaleaps

@cortinico cortinico Awaiting requested review from cortinico

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @facebook-github-bot