Cleanup the template after prefab support #34843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Historically we had to download an unzip the fbjni Android Archive to use it. Here I'm updating the way how we consume to use prefab so we can remove a lot of unnecessary configuration, also from the app template. Changelog: [Internal] [Changed] - Consume fbjni via Prefab Differential Revision: D39964574 fbshipit-source-id: ef1e8f07e57856fba2a518435ca73a2104ecefd9
Summary: We can now remove a lot of unnecessary code to copy .so files around as they're consumed via prefab from :ReactAndroid Changelog: [Android] [Changed] - Cleanup the Android template after prefab support Reviewed By: cipolleschi Differential Revision: D40014642 fbshipit-source-id: 5092f6204af3ff2a8b36da074030b8c69293875a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40014642 |
Base commit: 2319f75 |
Base commit: 2319f75 |
|
This pull request was successfully merged by @cortinico in 0b4417b. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34843 We can now remove a lot of unnecessary code to copy .so files around as they're consumed via prefab from :ReactAndroid Changelog: [Android] [Changed] - Cleanup the Android template after prefab support Reviewed By: cipolleschi Differential Revision: D40014642 fbshipit-source-id: 00e69ea62bdb4882b40b8b6f19cdf80235c847b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can now remove a lot of unnecessary code to copy .so
files around as they're consumed via prefab from :ReactAndroid
Changelog:
[Android] [Changed] - Cleanup the Android template after prefab support
Reviewed By: cipolleschi
Differential Revision: D40014642