Silence deprecation warning for react-native dependency. #34368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When a user runs `RCT_NEW_ARCH_ENABLED=1 pod install` to install the dependencies for the New Architecture, Cocoapods prints a warning because of React Native is still set up with a legacy configuration. This diff silences these warnings because they can confuse the final user. **Note:** We need to keep this legacy configuration to support both the legacy and the New Architecture. ## Changelog [iOS][Changed] - Silence warning due to react-native internal details. Differential Revision: D38503405 fbshipit-source-id: e26572579f149dd7b173b8838e9516383ddd1bf3
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38503405 |
cortinico
approved these changes
Aug 8, 2022
Base commit: a98da32 |
Base commit: dfd7f70 |
|
This pull request was successfully merged by @cipolleschi in a459922. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Aug 11, 2022
Summary: Pull Request resolved: #34368 When a user runs `RCT_NEW_ARCH_ENABLED=1 pod install` to install the dependencies for the New Architecture, Cocoapods prints a warning because of React Native is still set up with a legacy configuration. This diff silences these warnings because they can confuse the final user. **Note:** We need to keep this legacy configuration to support both the legacy and the New Architecture. ## Changelog [iOS][Changed] - Silence warning due to react-native internal details. Reviewed By: cortinico Differential Revision: D38503405 fbshipit-source-id: b89857aa88435b1c64da52875606003239ff2e05
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
) Summary: Pull Request resolved: facebook#34368 When a user runs `RCT_NEW_ARCH_ENABLED=1 pod install` to install the dependencies for the New Architecture, Cocoapods prints a warning because of React Native is still set up with a legacy configuration. This diff silences these warnings because they can confuse the final user. **Note:** We need to keep this legacy configuration to support both the legacy and the New Architecture. ## Changelog [iOS][Changed] - Silence warning due to react-native internal details. Reviewed By: cortinico Differential Revision: D38503405 fbshipit-source-id: b89857aa88435b1c64da52875606003239ff2e05
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
) Summary: Pull Request resolved: facebook#34368 When a user runs `RCT_NEW_ARCH_ENABLED=1 pod install` to install the dependencies for the New Architecture, Cocoapods prints a warning because of React Native is still set up with a legacy configuration. This diff silences these warnings because they can confuse the final user. **Note:** We need to keep this legacy configuration to support both the legacy and the New Architecture. ## Changelog [iOS][Changed] - Silence warning due to react-native internal details. Reviewed By: cortinico Differential Revision: D38503405 fbshipit-source-id: b89857aa88435b1c64da52875606003239ff2e05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When a user runs
RCT_NEW_ARCH_ENABLED=1 pod installto install the dependencies for the New Architecture, Cocoapods prints a warning because of React Native is still set up with a legacy configuration.This diff silences these warnings because they can confuse the final user.
Note: We need to keep this legacy configuration to support both the legacy and the New Architecture.
Changelog
[iOS][Changed] - Silence warning due to react-native internal details.
Differential Revision: D38503405