Fix Make Unused Not Compiler Specific #34357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 4899f8c |
Base commit: 4899f8c |
Contributor
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
javache
approved these changes
Aug 8, 2022
Collaborator
|
This pull request was successfully merged by @chiaramooney in 33dbb6c. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Use of `__attribute__` and `__unused` is compiler specific. Opt for standard `[[maybe_unused]]` instead. ## Changelog [General] [Fixed] - Remove compiler-specific syntax. Pull Request resolved: facebook#34357 Test Plan: Built on react-native-windows. Reviewed By: cipolleschi Differential Revision: D38498481 Pulled By: javache fbshipit-source-id: af43206788f54dda3b747b6417e20096c7d520e8
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Use of `__attribute__` and `__unused` is compiler specific. Opt for standard `[[maybe_unused]]` instead. ## Changelog [General] [Fixed] - Remove compiler-specific syntax. Pull Request resolved: facebook#34357 Test Plan: Built on react-native-windows. Reviewed By: cipolleschi Differential Revision: D38498481 Pulled By: javache fbshipit-source-id: af43206788f54dda3b747b6417e20096c7d520e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use of
__attribute__and__unusedis compiler specific. Opt for standard[[maybe_unused]]instead.Changelog
[General] [Fixed] - Remove compiler-specific syntax.
Test Plan
Built on react-native-windows.