Skip to content

fixed SDK issue while uploading app in debug scheme #33153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fixed SDK issue while uploading app in debug scheme #33153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d01c0fb
fixed SDK issue while uploading app in debug scheme
arinjay Feb 21, 2022
fac2652
trying to re-run the template-ios script
arinjay Feb 25, 2022
2f63cbc
Update React/DevSupport/RCTPackagerConnection.mm
arinjay May 6, 2022
432e7f2
Update React/DevSupport/RCTPackagerClient.h
arinjay May 6, 2022
6cd06c6
Update React/Base/RCTKeyCommands.m
arinjay May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions React/Base/RCTKeyCommands.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@

@interface UIEvent (UIPhysicalKeyboardEvent)

@property (nonatomic) NSString *_modifiedInput;
@property (nonatomic) NSString *_modifiedEventInput;
@property (nonatomic) NSString *_unmodifiedInput;
@property (nonatomic) UIKeyModifierFlags _modifierFlags;
@property (nonatomic) BOOL _isKeyDown;
@property (nonatomic) UIKeyModifierFlags _modifierEventFlags;
@property (nonatomic) BOOL _isKeyEventDown;
@property (nonatomic) long _keyCode;

@end
Expand Down Expand Up @@ -116,16 +116,16 @@ - (void)handleKeyUIEventSwizzle:(UIEvent *)event
UIKeyModifierFlags modifierFlags = 0;
BOOL isKeyDown = NO;

if ([event respondsToSelector:@selector(_modifiedInput)]) {
modifiedInput = [event _modifiedInput];
if ([event respondsToSelector:@selector(_modifiedEventInput)]) {
modifiedInput = [event _modifiedEventInput];
}

if ([event respondsToSelector:@selector(_modifierFlags)]) {
modifierFlags = [event _modifierFlags];
if ([event respondsToSelector:@selector(_modifierEventFlags)]) {
modifierFlags = [event _modifierEventFlags];
}

if ([event respondsToSelector:@selector(_isKeyDown)]) {
isKeyDown = [event _isKeyDown];
if ([event respondsToSelector:@selector(_isKeyEventDown)]) {
isKeyDown = [event _isKeyEventDown];
}

BOOL interactionEnabled = !UIApplication.sharedApplication.isIgnoringInteractionEvents;
Expand Down
2 changes: 1 addition & 1 deletion React/DevSupport/RCTPackagerClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extern const int RCT_PACKAGER_CLIENT_PROTOCOL_VERSION;
@protocol RCTPackagerClientMethod <NSObject>

- (void)handleRequest:(NSDictionary<NSString *, id> *)params withResponder:(RCTPackagerClientResponder *)responder;
- (void)handleNotification:(NSDictionary<NSString *, id> *)params;
- (void)handlePackagerNotification:(NSDictionary<NSString *, id> *)params;

@optional

Expand Down
2 changes: 1 addition & 1 deletion React/DevSupport/RCTPackagerConnection.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ - (void)addHandler:(id<RCTPackagerClientMethod>)handler forMethod:(NSString *)me

[self
addNotificationHandler:^(NSDictionary<NSString *, id> *notification) {
[handler handleNotification:notification];
[handler handlePackagerNotification:notification];
}
queue:queue
forMethod:method];
Expand Down