fix: pin hermes-engine to 0.7.x #30432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Contributor
Author
|
In the future, we may consider letting users change the version, just like we do for Flipper. Right now, I don't see such requirement. |
facebook-github-bot
added
CLA Signed
Contributor
|
I'm going to pull this into 0.64-stable ahead of this being merged. |
36 tasks
Contributor
|
@grabbou Do we still need this on main? Or can we close this? |
|
This PR is waiting for author's feedback since 24 days. Please provide the requested feedback or this will be closed in 7 days |
github-actions
bot
added
the
Stale
Contributor
|
Closing as the way how we consume Hermes has changed drastically and this is not relevant anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, Hermes is not pinned to any version and CocoaPods will install latest. This PR pins it using the same way Flipper is pinned, to keep it easier to track.
Changelog
[INTERNAL] [IOS] - Pin Hermes on iOS