iOS: Fix RCTDevLoadingView not showing up with UIScene #27916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
cc @hramos |
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @tido64 in 8ce27df. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
added
Merged
|
Sorry @tido64, this was reverted in 8c10147. Appears one of our internal apps ran into the following error: I'll have to take a look and see why this particular app has this issue. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 27, 2020
Summary: Attaches the loading view to a `UIScene` in apps using the new Scenes API (iOS 13+). ## Changelog [iOS] [Fixed] - Fix RCTDevLoadingView not showing up with UIScene Pull Request resolved: #27916 Test Plan: Create a new app based on UIScene and integrate React Native. | Before | After | |:------:|:------:| | <img width="453" alt="image" src="https://user-images.githubusercontent.com/4123478/73485717-eccfe800-43a3-11ea-96fd-f7077a348345.png"> | <img width="453" alt="image" src="https://user-images.githubusercontent.com/4123478/73485749-f9ecd700-43a3-11ea-8a18-2e2185e62e78.png"> | Reviewed By: PeteTheHeat Differential Revision: D20104655 Pulled By: hramos fbshipit-source-id: 86c1902c00f791fd23f75ea7562b44c92e719c5e
|
Tying loose ends here: I was able to get this change merged again in a separate commit. |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Attaches the loading view to a `UIScene` in apps using the new Scenes API (iOS 13+). ## Changelog [iOS] [Fixed] - Fix RCTDevLoadingView not showing up with UIScene Pull Request resolved: facebook#27916 Test Plan: Create a new app based on UIScene and integrate React Native. | Before | After | |:------:|:------:| | <img width="453" alt="image" src="https://user-images.githubusercontent.com/4123478/73485717-eccfe800-43a3-11ea-96fd-f7077a348345.png"> | <img width="453" alt="image" src="https://user-images.githubusercontent.com/4123478/73485749-f9ecd700-43a3-11ea-8a18-2e2185e62e78.png"> | Reviewed By: cpojer Differential Revision: D20008608 Pulled By: hramos fbshipit-source-id: ce59fd0b000d7dee51985a5533d9b5791687f592
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Attaches the loading view to a `UIScene` in apps using the new Scenes API (iOS 13+). ## Changelog [iOS] [Fixed] - Fix RCTDevLoadingView not showing up with UIScene Pull Request resolved: facebook#27916 Test Plan: Create a new app based on UIScene and integrate React Native. | Before | After | |:------:|:------:| | <img width="453" alt="image" src="https://user-images.githubusercontent.com/4123478/73485717-eccfe800-43a3-11ea-96fd-f7077a348345.png"> | <img width="453" alt="image" src="https://user-images.githubusercontent.com/4123478/73485749-f9ecd700-43a3-11ea-8a18-2e2185e62e78.png"> | Reviewed By: PeteTheHeat Differential Revision: D20104655 Pulled By: hramos fbshipit-source-id: 86c1902c00f791fd23f75ea7562b44c92e719c5e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attaches the loading view to a
UIScenein apps using the new Scenes API (iOS 13+).Changelog
[iOS] [Fixed] - Fix RCTDevLoadingView not showing up with UIScene
Test Plan
Create a new app based on UIScene and integrate React Native.