Skip to content

Change 'use' to 'lose' to signify that functions are still accessible #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2023
Merged

Change 'use' to 'lose' to signify that functions are still accessible #3949

merged 1 commit into from
Dec 9, 2023

Conversation

KartikShankhavaram
Copy link
Contributor

@KartikShankhavaram KartikShankhavaram commented Dec 8, 2023 •
edited
Loading

The statement at the end says that since the generated abstract class extends ReactContextBaseJavaModule, all the functions are still accessible. But the sentence reads "should not use" which does not make sense, and "should not lose" should be used instead.

@facebook-github-bot
Copy link

Hi @KartikShankhavaram!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ksshp ksshp mentioned this pull request Dec 8, 2023
Closed
@netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 47b927f
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/65747dbdd6a7c5000822ff10
😎 Deploy Preview https://deploy-preview-3949--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Simek
Simek reviewed Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction and backporting the changes! 👍

Can you resolve the conflict before we can ship? Looks like you have done PR in a small window when 0.73 docs were generated including minor version. The path should be just version-0.73 after rebase

Simek
Simek approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM! 👌

@Simek Simek merged commit 6a28b05 into facebook:main Dec 9, 2023
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Dec 10, 2023
@sunnylqm
Squashed commit of the following:
1f11d3d 
commit 6a28b05
Author: Kartik Shankhavaram <[email protected]>
Date:   Sat Dec 9 22:50:21 2023 +0800

    Change 'use' to 'lose' to signify that functions are still accessible (facebook#3949)

commit 822b280
Author: Alex Hunt <[email protected]>
Date:   Fri Dec 8 13:00:46 2023 +0000

    [docs] Fix name for 0.73 versioned docs (facebook#3948)

commit 4818763
Author: Nick Gerleman <[email protected]>
Date:   Thu Dec 7 10:56:32 2023 -0800

    Lint and typecheck examples against RN 0.73 (facebook#3946)

    * Lint and typecheck examples against RN 0.73

    Updates the harness for linting snack examples to the newest version of RN.

    * Update Netlify Node version

commit cc46589
Author: Nick Gerleman <[email protected]>
Date:   Thu Dec 7 10:56:04 2023 -0800

    Add `alignContent: 'space-evenly'` (facebook#3888)

    * Add `alignContent: 'space-evenly'`

    Coming with 0.74

    facebook/react-native#41020

    * Update layout-props.md

commit 9f7093c
Author: Christoph Purrer <[email protected]>
Date:   Thu Dec 7 14:06:00 2023 +0100

    Simplify C++ TM struct generation (facebook#3947)

    Update documentation to match:
    facebook/react-native#41645

commit 59278e7
Author: Nick Gerleman <[email protected]>
Date:   Thu Dec 7 01:28:12 2023 -0800

    Add `--frozen-lockfile` to `yarn install` (facebook#3945)

    To catch cases where dependency changes require a lockfile change that wasn't comited alongside.

commit 06ba8ea
Author: Nick Gerleman <[email protected]>
Date:   Thu Dec 7 00:59:10 2023 -0800

    Revert "fixed peer dependency issues (facebook#3942)" (facebook#3944)

    This reverts commit 1bcb60f.

commit 1bcb60f
Author: Shantanu Gupta <[email protected]>
Date:   Thu Dec 7 08:52:32 2023 +0000

    fixed peer dependency issues (facebook#3942)

    * fixed peer dependency issues

    * removed lingering file

commit 79ff42a
Author: Zeya Peng <[email protected]>
Date:   Wed Dec 6 14:20:06 2023 -0500

    Update native-components-android.md (facebook#3941)

commit f0c4b80
Author: Aike van den Brink <[email protected]>
Date:   Wed Dec 6 19:46:03 2023 +0100

    Update new-architecture-app-intro.md (facebook#3938)

    Fixed small spelling mistake

commit f89ab82
Author: Alex Hunt <[email protected]>
Date:   Wed Dec 6 17:56:40 2023 +0000

    [docs] Cut version 0.73.0 (facebook#3940)

commit 83e816b
Author: Alex Hunt <[email protected]>
Date:   Wed Dec 6 17:15:14 2023 +0000

    [blog] Add 0.73 announcement post (facebook#3931)

commit d8c78ad
Author: Thibault Malbranche <[email protected]>
Date:   Wed Dec 6 17:33:48 2023 +0100

    fix(Image): update link to correct file (facebook#3939)

commit 821172e
Author: Sarvar Rose <[email protected]>
Date:   Mon Dec 4 16:20:11 2023 +0530

    correct type of Pressable `style` prop (facebook#3936)

commit b1379a7
Author: adriancuadrado <[email protected]>
Date:   Mon Dec 4 00:57:19 2023 +0100

    Update scrollview.md (facebook#3869)

    `pagingEnabled` **is** supported on Android. I tested it and it just seems to work.

commit 11258b1
Author: Alan <[email protected]>
Date:   Mon Dec 4 07:55:12 2023 +0800

    fix: remove useless points (facebook#3934)

commit 8400279
Author: Christoph Purrer <[email protected]>
Date:   Sun Dec 3 09:57:25 2023 +0100

    Revert "Simplify C++ TM struct generation (facebook#3930)" (facebook#3935)

    This reverts commit 7396470.

commit 7396470
Author: Christoph Purrer <[email protected]>
Date:   Mon Nov 27 13:00:23 2023 +0100

    Simplify C++ TM struct generation (facebook#3930)

    Update documentation to match:
    facebook/react-native#41645

commit 5616873
Author: Bailey Lissington <[email protected]>
Date:   Mon Nov 27 22:33:50 2023 +1300

    Fixed grammatical error (facebook#3929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simek Simek Simek approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KartikShankhavaram @facebook-github-bot @Simek