-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Update use-app-template.md #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ruby function `install_modules_dependencies` was added in 0.71.0-rc.3 facebook/react-native@82e9c6a
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm not sure I follow why you want to make this change. |
@cortinico The podspec file uses the ruby function |
Yup, but you're updating the documentation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should generally avoid adding version numbers in documents like this since they age poorly. E.g. the document will stay the same once 0.72 comes out.
The documents are versioned though, so the contents of the current page will only be showed for the 0.71 version of the website, and not the versions before it.
True. Yet for the New Architecture setup, the version number is sort of crucial IMHO as we're keep on iterating on the migration path. |
Hi @Gregoirevda, thank you a lot for the PR. However, I don't think we have to merge this. The
You are suggesting to change the
What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
Makes sense to not include version numbers, especially RC. Just a matter of time before |
ruby function
install_modules_dependencies
was added in 0.71.0-rc.3 facebook/react-native@82e9c6a