feat: Add inset logical properties #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
TIL I have permissions to this repo |
Contributor
|
facebook/react-native#35572 is landing now, and I'm following up with the internally running screenshot tests. @gabrieldonadel you should be safe now to add the prop-types here as well. |
Contributor
|
I'm going to add this repo to the list with generate notifications for our oncall on PR as well, since it's low-traffic enough that I am not sure folks are religiously checking it. |
Contributor
Done. Future PRs to this repo will generate Workplace notifications internally now. |
Contributor
Author
|
Sounds good, thanks @NickGerleman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the DeprecatedLayoutPropTypes to include the inset logical properties introduced by facebook/react-native@9669c10.